Allow js as a code-snippet language#17
Merged
tannerlinsley merged 1 commit intoTanStack:mainfrom Jul 19, 2022
Merged
Conversation
The react-query documents contain markdown files with js as a code-snippet language. These show up (incorrectly) as bash in the documentation.
|
@dglsparsons is attempting to deploy a commit to the Tanstack Team on Vercel. A member of the Team first needs to authorize it. |
dglsparsons
added a commit
to dglsparsons/query
that referenced
this pull request
Jul 19, 2022
The tanstack.com site shows the code-snippets as `bash` as a fallback, as js is not expected as a language type. (see [here](https://github.com/TanStack/tanstack.com/blob/main/app/components/CodeBlock.tsx) for allowed language types). In addition to allowing JS as a snippet type (TanStack/tanstack.com#17), changing the documentation to be `tsx` ensures that syntax highlighting and the language type appears correct.
dglsparsons
added a commit
to dglsparsons/query
that referenced
this pull request
Jul 19, 2022
The tanstack.com site shows the code-snippets as `bash` as a fallback, as js is not expected as a language type. (see [here](https://github.com/TanStack/tanstack.com/blob/main/app/components/CodeBlock.tsx) for allowed language types). In addition to allowing JS as a snippet type (TanStack/tanstack.com#17), changing the documentation to be `tsx` ensures that syntax highlighting and the language type appears correct.
TkDodo
added a commit
to TanStack/query
that referenced
this pull request
Jul 19, 2022
* Change docs code-snippet types to tsx The tanstack.com site shows the code-snippets as `bash` as a fallback, as js is not expected as a language type. (see [here](https://github.com/TanStack/tanstack.com/blob/main/app/components/CodeBlock.tsx) for allowed language types). In addition to allowing JS as a snippet type (TanStack/tanstack.com#17), changing the documentation to be `tsx` ensures that syntax highlighting and the language type appears correct. * Apply suggestions from code review * Update docs/guides/disabling-queries.md Co-authored-by: Dominik Dorfmeister <office@dorfmeister.cc>
Olaf0703
added a commit
to Olaf0703/query
that referenced
this pull request
Feb 28, 2023
* Change docs code-snippet types to tsx The tanstack.com site shows the code-snippets as `bash` as a fallback, as js is not expected as a language type. (see [here](https://github.com/TanStack/tanstack.com/blob/main/app/components/CodeBlock.tsx) for allowed language types). In addition to allowing JS as a snippet type (TanStack/tanstack.com#17), changing the documentation to be `tsx` ensures that syntax highlighting and the language type appears correct. * Apply suggestions from code review * Update docs/guides/disabling-queries.md Co-authored-by: Dominik Dorfmeister <office@dorfmeister.cc>
Cute0110
added a commit
to Cute0110/TanStack-Query
that referenced
this pull request
Sep 28, 2023
* Change docs code-snippet types to tsx The tanstack.com site shows the code-snippets as `bash` as a fallback, as js is not expected as a language type. (see [here](https://github.com/TanStack/tanstack.com/blob/main/app/components/CodeBlock.tsx) for allowed language types). In addition to allowing JS as a snippet type (TanStack/tanstack.com#17), changing the documentation to be `tsx` ensures that syntax highlighting and the language type appears correct. * Apply suggestions from code review * Update docs/guides/disabling-queries.md Co-authored-by: Dominik Dorfmeister <office@dorfmeister.cc>
SerhiiMisiura
added a commit
to SerhiiMisiura/TanStack-Query
that referenced
this pull request
Oct 6, 2023
* Change docs code-snippet types to tsx The tanstack.com site shows the code-snippets as `bash` as a fallback, as js is not expected as a language type. (see [here](https://github.com/TanStack/tanstack.com/blob/main/app/components/CodeBlock.tsx) for allowed language types). In addition to allowing JS as a snippet type (TanStack/tanstack.com#17), changing the documentation to be `tsx` ensures that syntax highlighting and the language type appears correct. * Apply suggestions from code review * Update docs/guides/disabling-queries.md Co-authored-by: Dominik Dorfmeister <office@dorfmeister.cc>
gheith-abinader
pushed a commit
to gheith-abinader/tanstack-query-docs-react
that referenced
this pull request
Sep 21, 2025
* Change docs code-snippet types to tsx The tanstack.com site shows the code-snippets as `bash` as a fallback, as js is not expected as a language type. (see [here](https://github.com/TanStack/tanstack.com/blob/main/app/components/CodeBlock.tsx) for allowed language types). In addition to allowing JS as a snippet type (TanStack/tanstack.com#17), changing the documentation to be `tsx` ensures that syntax highlighting and the language type appears correct. * Apply suggestions from code review * Update docs/guides/disabling-queries.md Co-authored-by: Dominik Dorfmeister <office@dorfmeister.cc>
LeCarbonator
pushed a commit
to LeCarbonator/tanstack.com
that referenced
this pull request
Jan 11, 2026
Allow js as a code-snippet language
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The react-query documents contain markdown files with js as a code-snippet language.
These show up (incorrectly) as bash in the documentation.